Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xdebug always enabled #1727

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix xdebug always enabled #1727

merged 2 commits into from
Jan 6, 2025

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Dec 19, 2024 •
edited
Loading

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fix xdebug always enabled

@SamuelWei SamuelWei added this to the v4.2 milestone Dec 19, 2024
@SamuelWei SamuelWei added the bug Something isn't working label Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (b030a62) to head (631bec9).
Report is 19 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #1727   +/-   ##
==========================================
  Coverage      81.01%   81.01%           
  Complexity      1340     1340           
==========================================
  Files            361      361           
  Lines           9225     9225           
  Branches         853      853           
==========================================
  Hits            7474     7474           
  Misses          1751     1751

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Dec 19, 2024 •
edited
Loading

PILOS    Run #1576

Run Properties:  status check passed Passed #1576  •  git commit c7de698274: Fix xdebug always enabled (#1727)
Project PILOS
Branch Review develop
Run status status check passed Passed #1576
Run duration 04m 53s
Commit git commit c7de698274: Fix xdebug always enabled (#1727)
Committer Samuel Weirich
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 237
View all changes introduced in this branch ↗︎

@SamuelWei
Copy link
Collaborator Author

https://laravel-news.com/flexible-docker-images-with-php-ini-environment-variables

@SamuelWei SamuelWei requested review from danielmachill and removed request for danielmachill January 6, 2025 13:07
@SamuelWei SamuelWei merged commit c7de698 into develop Jan 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmachill danielmachill Awaiting requested review from danielmachill

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@SamuelWei